Update style of key binding UI#38166
Merged
Merged
Conversation
This PR refreshes the appearance of `KeyBindingRow` to better match the new form controls used in the settings overlay. It also gets rid of the previously used font on the actual key display with Torus.
bdach
added
type/cosmetic
Member
|
Made some adjustments: 2026-06-30.01.44.37.mp4 |
peppy
approved these changes
Jun 29, 2026
peppy
left a comment
peppy
left a comment
Member
There was a problem hiding this comment.
Not sure about the grid container usage but too sleepy to care
Contributor
Author
|
afaik the previous implementation would cause the label to overlap with the key displays if the text was too long. from what I can tell this never happened (at the very least on English) so maybe I am too cautious here. |
peppy
approved these changes
Jun 29, 2026
0xAlexisSys
pushed a commit
to 0xAlexisSys/osu
that referenced
this pull request
Jun 30, 2026
This PR refreshes the appearance of `KeyBindingRow` to better match the new form controls used in the settings overlay. It also gets rid of the previously used font on the actual key display with Torus. [Screencast_20260626_183457.webm](https://github.com/user-attachments/assets/71a1a5b5-ec6d-4f54-af3a-d5a3bb807521) The Cancel/Clear buttons look a bit out of place with the non-matching corner radius, but I suppose it will be eventually handled once https://github.com/ppy/osu/blob/master/osu.Game/Graphics/UserInterfaceV2/RoundedButton.cs#L52 is sorted out. --------- Co-authored-by: Dean Herbert <pe@ppy.sh>
0xAlexisSys
pushed a commit
to 0xAlexisSys/osu
that referenced
this pull request
Jun 30, 2026
This PR refreshes the appearance of `KeyBindingRow` to better match the new form controls used in the settings overlay. It also gets rid of the previously used font on the actual key display with Torus. [Screencast_20260626_183457.webm](https://github.com/user-attachments/assets/71a1a5b5-ec6d-4f54-af3a-d5a3bb807521) The Cancel/Clear buttons look a bit out of place with the non-matching corner radius, but I suppose it will be eventually handled once https://github.com/ppy/osu/blob/master/osu.Game/Graphics/UserInterfaceV2/RoundedButton.cs#L52 is sorted out. --------- Co-authored-by: Dean Herbert <pe@ppy.sh>
0xAlexisSys
pushed a commit
to 0xAlexisSys/osu
that referenced
this pull request
Jul 7, 2026
This PR refreshes the appearance of `KeyBindingRow` to better match the new form controls used in the settings overlay. It also gets rid of the previously used font on the actual key display with Torus. [Screencast_20260626_183457.webm](https://github.com/user-attachments/assets/71a1a5b5-ec6d-4f54-af3a-d5a3bb807521) The Cancel/Clear buttons look a bit out of place with the non-matching corner radius, but I suppose it will be eventually handled once https://github.com/ppy/osu/blob/master/osu.Game/Graphics/UserInterfaceV2/RoundedButton.cs#L52 is sorted out. --------- Co-authored-by: Dean Herbert <pe@ppy.sh>
0xAlexisSys
pushed a commit
to 0xAlexisSys/osu
that referenced
this pull request
Jul 9, 2026
This PR refreshes the appearance of `KeyBindingRow` to better match the new form controls used in the settings overlay. It also gets rid of the previously used font on the actual key display with Torus. [Screencast_20260626_183457.webm](https://github.com/user-attachments/assets/71a1a5b5-ec6d-4f54-af3a-d5a3bb807521) The Cancel/Clear buttons look a bit out of place with the non-matching corner radius, but I suppose it will be eventually handled once https://github.com/ppy/osu/blob/master/osu.Game/Graphics/UserInterfaceV2/RoundedButton.cs#L52 is sorted out. --------- Co-authored-by: Dean Herbert <pe@ppy.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refreshes the appearance of
KeyBindingRowto better match the new form controls used in the settings overlay. It also gets rid of the previously used font on the actual key display with Torus.Screencast_20260626_183457.webm
The Cancel/Clear buttons look a bit out of place with the non-matching corner radius, but I suppose it will be eventually handled once https://github.com/ppy/osu/blob/master/osu.Game/Graphics/UserInterfaceV2/RoundedButton.cs#L52 is sorted out.